Skip to content

Conversation

srini047
Copy link
Contributor

Related Issues

Proposed Changes:

Added support for GitHubRepoForkerTool to the GitHub intergrations.

How did you test it?

Added a test file to test the tool.

Notes for the reviewer

Checklist

@srini047 srini047 requested a review from a team as a code owner June 17, 2025 20:52
@srini047 srini047 requested review from mpangrazzi and removed request for a team June 17, 2025 20:52
@github-actions github-actions bot added integration:github type:documentation Improvements or additions to documentation labels Jun 17, 2025
@srini047 srini047 force-pushed the github_repo_forker_tool_integration branch from 4679dc7 to c3b4cfd Compare June 17, 2025 20:54
Copy link
Contributor

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've left some comments!

@srini047 srini047 requested a review from mpangrazzi June 28, 2025 15:09
@anakin87
Copy link
Member

anakin87 commented Jul 1, 2025

⚠️ I fixed types for this integration in #2024, so I recommend merging main and fixing potential conflicts and test failures.

@srini047 srini047 force-pushed the github_repo_forker_tool_integration branch from 57acc3a to 47a1c1f Compare July 12, 2025 06:26
@srini047
Copy link
Contributor Author

@mpangrazzi Can you please review it.

@srini047 srini047 force-pushed the github_repo_forker_tool_integration branch from 8a8db43 to 4cd1b86 Compare July 12, 2025 06:41
Copy link
Contributor

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srini047 there's a change still need to be reverted. Apart from this, everything else looks ok to me.

@srini047
Copy link
Contributor Author

srini047 commented Jul 24, 2025

@mpangrazzi Can you help me unblock in this PR. Many cases are failing for GithubRepoForker. I wasn't able to debug the issue.

@srini047
Copy link
Contributor Author

srini047 commented Aug 8, 2025

@sjrl @mpangrazzi
I see other components tests passing. What else are we missing here?

@srini047
Copy link
Contributor Author

@sjrl @mpangrazzi
Fixed all the issues. Please review.

@mpangrazzi mpangrazzi self-requested a review August 18, 2025 13:14
Copy link
Contributor

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for you work!

@mpangrazzi mpangrazzi merged commit 6adb8f1 into deepset-ai:main Aug 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:github type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHubRepoForkerTool to GitHub integration
4 participants