fix: remove duplicate kv_indptr loop in benchmark#134
Open
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Open
fix: remove duplicate kv_indptr loop in benchmark#134yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Conversation
The loop at lines 100-101 incorrectly extended kv_indptr a second time after the main loop (lines 94-99) had already built the complete array. This caused kv_indptr to have 2*b elements instead of the correct b+1 elements, leading to incorrect benchmark results for flashinfer comparison. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kv_indptra second time inrun_flash_infer()functioncache_seqlens[1:]and appending tokv_indptrafter the main loop (lines 94-99) had already built the complete arraykv_indptrto have2*belements instead of the correctb+1elementsTest plan
🤖 Generated with Claude Code