fix: improve build error messages and add architecture status output#128
Open
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Open
fix: improve build error messages and add architecture status output#128yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Conversation
Build system improvements: - Replace cryptic assertion with clear RuntimeError messages - Add helpful guidance when CUDA version is too old for SM100 - Show which GPU architectures are enabled during compilation - Add error handling for missing/broken CUDA installations - Prevent silent failures when no architectures are enabled Python code style: - Use `assert not causal` instead of `assert causal == False` (PEP 8) - Improve assertion error message clarity These changes help users quickly diagnose and fix build issues, especially when using older CUDA versions with Hopper GPUs. Relates to deepseek-ai#79 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the build experience by providing clearer error messages and better feedback during compilation.
Build System Improvements
assertwith descriptiveRuntimeErrormessagesExample: New Error Message for CUDA < 12.9
Before:
After:
Python Code Style
assert not causalinstead ofassert causal == False(PEP 8 E712)Test plan
FLASH_MLA_DISABLE_SM100=1Relates to #79
🤖 Generated with Claude Code