fix: use c10::DeviceIndex instead of char for CUDAGuard on aarch64#127
Open
yurekami wants to merge 2 commits intodeepseek-ai:mainfrom
Open
fix: use c10::DeviceIndex instead of char for CUDAGuard on aarch64#127yurekami wants to merge 2 commits intodeepseek-ai:mainfrom
yurekami wants to merge 2 commits intodeepseek-ai:mainfrom
Conversation
On aarch64, char is unsigned by default, while c10::DeviceIndex is defined as signed char. This causes narrowing conversion warnings when building on ARM platforms (e.g., during vllm build). Replace (char) casts with static_cast<c10::DeviceIndex>() for proper cross-platform compatibility. Fixes deepseek-ai#93 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fix spelling error in SM100 Dense MLA error messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(char)casts withstatic_cast<c10::DeviceIndex>()in CUDAGuard callscharis unsigned by defaultsigned char, causing-Wnarrowingwarnings when usingcharon ARMChanges
csrc/pybind.cpplines 153, 263, 422: Usestatic_cast<c10::DeviceIndex>()instead of(char)Test plan
Fixes #93
🤖 Generated with Claude Code