Skip to content

Conversation

zhoutianzi666
Copy link

@zhoutianzi666 zhoutianzi666 commented Aug 9, 2025

code seems redundant,
I delete some logic using cg::this_grid().sync() instead ?

@zhoutianzi666 zhoutianzi666 changed the title delete some redundant logic delete some redundant logic us cg::this_grid().sync(); Aug 9, 2025
@zhoutianzi666 zhoutianzi666 changed the title delete some redundant logic us cg::this_grid().sync(); delete some redundant logic using cg::this_grid().sync(); Aug 9, 2025
@alpha-baby
Copy link
Contributor

maybe reduce performance when directly use cg::this_grid().sync();

@sphish
Copy link
Collaborator

sphish commented Aug 13, 2025

The original code logic was intended to allow the NIC to start working as early as possible, thereby reducing latency. This is especially beneficial when the batch size is small. Have you tested the performance impact of your changes?

@zhoutianzi666
Copy link
Author

zhoutianzi666 commented Aug 19, 2025

The original code logic was intended to allow the NIC to start working as early as possible, thereby reducing latency. This is especially beneficial when the batch size is small. Have you tested the performance impact of your changes?

I tested, it does not hurt performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants