Skip to content

Conversation

@A-006
Copy link
Collaborator

@A-006 A-006 commented Jan 28, 2026

PR Description:
This PR introduces changes to the Parallel_Reduce namespace to standardize reduction operations across the codebase.

Key Changes:

  • Refactoring: Updated reduce_all and reduce_pool interfaces in parallel_reduce.cpp and parallel_reduce.h to support more types and consistent templating.
  • Usage Updates: Adjusted reduce_max and reduce_min calls in sto_iter.cpp and sto_tool.cpp to properly handle value references (fixing pointer dereferencing issues).
  • Optimization: Improved reduce_double_allpool implementation to perform in-place MPI reduction, avoiding auxiliary vector allocation.
  • Test Fixes: Updated depend_mock files in source_basis/module_pw/test to include missing reduce_min_pool mock definitions, fixing pw_test link errors.
  • Compilation Fixes: Resolved various compilation issues in module_charge, module_pwdft, and module_stodft related to the interface changes.

@mohanchen mohanchen added Refactor Refactor ABACUS codes GPU & DCU & HPC GPU and DCU and HPC related any issues The Absolute Zero Reduce the "entropy" of the code to 0 labels Jan 29, 2026
@mohanchen mohanchen merged commit bcb06d8 into deepmodeling:develop Jan 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GPU & DCU & HPC GPU and DCU and HPC related any issues Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants