Skip to content

Conversation

@dsmmcken
Copy link
Contributor

For upcoming support of nested ui.dashboards. Gives a visual boundry of the nested layout, showing that children can't be dragged out of the nested layout.

Relates to: deephaven/deephaven-plugins#1238

@dsmmcken dsmmcken requested a review from mofojed October 30, 2025 22:13
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.36%. Comparing base (4d7c106) to head (8eef6c3).

Files with missing lines Patch % Lines
packages/golden-layout/src/utils/DragListener.ts 0.00% 5 Missing ⚠️
.../golden-layout/src/controls/DragSourceFromEvent.ts 0.00% 3 Missing ⚠️
packages/golden-layout/src/controls/DragSource.ts 0.00% 1 Missing ⚠️
packages/golden-layout/src/controls/Tab.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2560      +/-   ##
==========================================
+ Coverage   44.11%   44.36%   +0.25%     
==========================================
  Files         764      764              
  Lines       43104    43110       +6     
  Branches    10895    10897       +2     
==========================================
+ Hits        19014    19125     +111     
+ Misses      24074    23969     -105     
  Partials       16       16              
Flag Coverage Δ
unit 44.36% <9.09%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dsmmcken dsmmcken merged commit e076af5 into main Oct 31, 2025
11 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_lm_drag_root branch October 31, 2025 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants