Make image pull secret optional #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where the Helm chart may not require credentials to access the Deepgram container image repositories hosted on Quay. This PR removes the firm requirement to include these credentials as a pull secret for pulling container images.
For example, a client may pull the images from Quay manually and push them into a private company repository that meets certain security or scanning requirements. Credentials to that private repo may be pre-configured in the cluster, so the pull secret shouldn't be mandatory.
Another case is if a Docker proxy is being used and credentials are supplied in the proxy. Then the credentials don't need to be exposed directly in the cluster with this Helm chart.
Resolves #14.