CI: fail on test errors #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longzheng
changed the title
|
I'm not 100% sure if the test command also needs a change since currently it has Line 48 in 7ce44bd |
longzheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging another issue I noticed that there is actually a test failing but the CI is reporting all good. For example the last CI run https://github.com/deepgram/deepgram-js-sdk/actions/runs/9403306912/job/25899538297#step:4:120
I saw it's because the CI is only running the
npm run test:coveragewhich doesn't seem to throw an error if there are test errors.I thought the easiest fix is to just run the test separately to generating the coverage.