-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use Flask-SocketIO and get audio from browser mic #4
Conversation
Thank you @etiennecallies for this PR. I apologize it took so long to review it! I have made changes to your PR based on the Python SDK's recommended implementation. So it now gives a good example for how to use the Python SDK for this use case. I also use the most updated version of the SDK. If you have a chance to run the code again and give feedback, I would appreciate it! |
Hi @SandraRodgers ! No worries, it's an honor to become a contributor ;) I just tried it and it works fine 👌🏻 Congrats! Good job on the code refactoring. My only remark is that we could use only one port (and it's my fault). Here is how:
All the best |
@etiennecallies I created an issue so that I don't forget to make this update (I'm working on other things at the moment). If you feel like submitting another PR, that would be welcome! |
No description provided.