Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should remove need for bonzo.create()ing markup. #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Should remove need for bonzo.create()ing markup. #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/bonzo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,11 @@
function Bonzo(elements) {
this.length = 0
if (elements) {
elements = typeof elements !== 'string' &&
!elements.nodeType &&
typeof elements.length !== 'undefined' ?
elements :
[elements]
elements = typeof elements === 'string' &&
!/^\s*</.test(elements) &&
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this regex literal won't work in IE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Garrrrh, really? What about it? Would !new RegExp("^\\s*<").test(elements) be any better?

I actually have IE, but unfortunately I'm not firing it up to test this, since every time I open it, it crashes my machine. :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. I'm not sure it's actually going to be a problem as-is in IE. You could paren for clarity: !(/^\s*</).test(elements).
In any case, a good unit test suite will pick up any problems with old IE so working on that should be your next task to figure out.

If you want a full IE test suite then you can download and use these virtual machine images direct from Microsoft exactly for this purpose: http://www.microsoft.com/en-us/download/details.aspx?id=11575

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I suppose I should've said it tends to crash my machine... I gave it a try with all my work saved, and it ended up working. So I know it def works with IE8, not to say anything of the others, because this prints falsetrue.

I'll work on the test suite some time soon, though I may (or may not) need some pointers when I do. :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. what i meant was that it just needed the parens..... 11 months later

query ?
query(elements) :
normalize(elements)
this.length = elements.length
for (var i = 0; i < elements.length; i++) this[i] = elements[i]
}
Expand Down