stakedb: upgrade ticket pool badger DB from v1.6.2 to v3.2103.2 #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukane-philemon
force-pushed
the
upgradebadger
branch
from
cd2c712
to
ea46574
Compare
chappjc
reviewed
Dec 14, 2022
chappjc
reviewed
Dec 14, 2022
ukane-philemon
force-pushed
the
upgradebadger
branch
from
ea46574
to
bbae785
Compare
- This make some major improvement to the ticket pool upgrade path and moves upgrade related code to a stakeDB/upgrade.go file.
ukane-philemon
force-pushed
the
upgradebadger
branch
2 times, most recently
from
08ff081
to
6d0c54f
Compare
ukane-philemon
commented
Dec 15, 2022
ukane-philemon
commented
Dec 15, 2022
ukane-philemon
force-pushed
the
upgradebadger
branch
from
6d0c54f
to
36cd18c
Compare
ukane-philemon
force-pushed
the
upgradebadger
branch
from
36cd18c
to
9c7ebef
Compare
chappjc
reviewed
Dec 15, 2022
chappjc
reviewed
Dec 15, 2022
chappjc
reviewed
Dec 15, 2022
|
While badger is running fine, I've been getting these logs. Do you think we need to increase the block cache beyond the default? |
To determine that, we'll have to deploy to see a real use case, otherwise it's just append-only with no gets. Try testing the "full" ticket pool API endpoint, traversing to pool snapshots at distant heights. Compare performance with badger v1 and with different cache settings for v3. |
Don't know how long for badger v1 cuz I've upgraded already. @chappjc, can you check how long for v1? |
|
To specify a snapshot at a given block, use the
endpoint: /stake/pool/b/{idxorhash}/full
…On Thu, Dec 22, 2022, 1:09 AM Philemon Ukane ***@***.***> wrote:
2022/12/22 06:55:30 "GET http://134.209.25.156:7777/api/stake/pool/full HTTP/1.1" from 105.113.40.37:29560 - 200 2731123B in 824.332317ms
2022/12/22 06:55:47 "GET http://134.209.25.156:7777/api/stake/pool/full HTTP/1.1" from 105.113.40.37:30039 - 200 2731123B in 708.798579ms
2022/12/22 06:56:01 "GET http://134.209.25.156:7777/api/stake/pool/full HTTP/1.1" from 105.113.40.37:30430 - 200 2731123B in 797.757222ms
Don't know how long for badger v1 cuz I've upgraded already. @chappjc
<https://github.com/chappjc>, can you check how long for v1?
—
Reply to this email directly, view it on GitHub
<#1948 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHQOSKHYUG6GDNNTG7ZHWDWOP5CDANCNFSM6AAAAAAS6RT66U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This comment was marked as resolved.
This comment was marked as resolved.
ukane-philemon
force-pushed
the
upgradebadger
branch
from
1b474c0
to
7fd8e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the badger DB used by the ticket pool from v1.6.2 to v3.2103.2. Closes #1750.
Successful upgrade log
EDIT:
Successful upgrade log