blockchain: Use new style for chainio test errors. #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
approved these changes
Feb 17, 2021
rstaudt2
force-pushed
the
update-chainio-test-error-messages
branch
2 times, most recently
from
b24aacf
to
43977f8
Compare
davecgh
added
the
test coverage
|
Need a rebase and then it's good to go. |
This updates the error messages in the chainio tests to consistently use
the newer style of `t.Errorf("%q: ...", test.name)` rather than
including extra information for the function name, test index, etc.
The extra information is no longer needed to pinpoint an error since the
test framework now shows proper line numbers for any errors that occur.
rstaudt2
force-pushed
the
update-chainio-test-error-messages
branch
from
43977f8
to
df657b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #2591.
This updates the error messages in the chainio tests to consistently use the newer style of
t.Errorf("%q: ...", test.name)rather than including extra information for the function name, test index, etc. The extra information is no longer needed to pinpoint an error since the test framework now shows proper line numbers for any errors that occur.