blockchain: Remove easiest diff checkpoint checks. #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
Nov 27, 2019
dnldd
approved these changes
Dec 2, 2019
These checks are no longer necessary since they applied to orphans and blockchain no longer handles orphans. Further, orphans are currently otherwise limited by the block manager and this is another step towards the overall effort to decouple the connection code from the download logic. Ultimately, the goal is to remove orphan handling altogether. Finally, it also has the added benefit of further minimizing the reliance on trusted known good checkpoints.
davecgh
force-pushed
the
blockchain_remove_easiest_diff_checks
branch
from
0092697
to
7fd7f7b
Compare
jrick
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #2008.
These checks are no longer necessary since they applied to orphans and blockchain no longer handles orphans. Further, orphans are currently otherwise limited by the block manager and this is another step towards the overall effort to decouple the connection code from the download logic. Ultimately, the goal is to remove orphan handling altogether.
Finally, it also has the added benefit of further minimizing the reliance on trusted known good checkpoints.