Feature: add humidity display #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdstouter
changed the title
decompil3d
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Hi - thanks for the contribution 😃 Can you please add tests to cover this new functionality? I see that you've already added the requisite test data, but you need to add some actual test cases that verify that we don't show humidity when it's not configured, but do show it when it is configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
The goal of this PR is to add support for displaying humidity values in the hourly forecast. I put this together very quickly, but I'd be more than happy to make changes as needed. At the moment, I have it running in my local HA instance, and it works great!
I basically just duplicated the precipitation probability feature and modified it to use humidity instead. I also added all of the translations for the UI, although they have been done with Google Translate so I don't know how accurate they are.
This PR closes #525
UI example
YAML Configuration
A
show_humidityoption has been added to the configuration that can be set to true or false.