Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linx Impulse Loader (similarItems) #164

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix Linx Impulse Loader (similarItems) #164

wants to merge 7 commits into from

Conversation

gustavo-vasconcellos
Copy link
Collaborator

@gustavo-vasconcellos gustavo-vasconcellos commented Jul 26, 2023 •
edited
Loading

  • Add extract ID from param function
  • Fix method to get shelfs
  • Remove position props and search on each position property (top, middle, bottom)

Admin to test: https://deco.cx/admin/sites/xpto/blocks/Product%20Page
Branch: fix/linx

image

@tlgimenes
Copy link
Contributor

I didn't really get it. Can't we just use other paths/slugs so we don't need to regex it?

@gustavo-vasconcellos gustavo-vasconcellos changed the title fix(similarItems): add regex logic and remove slug from props Fix Linx Impulse Loader (similarItems) Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlgimenes tlgimenes tlgimenes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavo-vasconcellos @tlgimenes