Remove ratings that were found

Signed-off-by: Marcos Candeia <[email protected]>
deco-sites · Apr 15, 2023 · 61ef409 · 61ef409
1 parent ff95523
commit 61ef409
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/extensions/yourViews.ts b/extensions/yourViews.ts
@@ -58,9 +58,15 @@ const sameOrder = (
   productIds: readonly string[],
   elements: Rating[],
 ): (Rating | undefined)[] => {
-  const ordered = new Array<Rating | undefined>(productIds.length);
+  const ordered = new Array<Rating | undefined>(productIds.length).fill(
+    undefined,
+  );
   for (let i = 0; i < productIds.length; i++) {
-    ordered[i] = elements.find((e) => e.ProductId === productIds[i]);
+    const ratingIdx = elements.findIndex((e) => e.ProductId === productIds[i]);
+    if (ratingIdx !== -1) {
+      ordered[i] = elements[ratingIdx];
+      elements.splice(ratingIdx, 1); // remove already found rating
+    }
   }
   return ordered;
 };