Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access wrapper duplicate type #273

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Commits on Jul 21, 2023

  1. CancelRequests - Allow multiple cancel request writers in a single job

    Add the ability to require multiple cancel streams in a single job. Requiring is done as you would expect, just target the different streams on the JobConfig. Fulfilling the writer/instance is done by passing the stream instance into the `Fulfill` method.
    
    The access wrappers now represent access to the cancel type not a specific cancel stream instance. This works because all of the cancel streams share the same SharedWrite Pending collection so getting write access for one stream grants write access for all. The instance passed through `Fulfill` will get safety checked in the access wrapper and delivered back to be used for writer creation.
    
    Behaviour:
     - One cancel request stream required: `jobData.Fulfill` behaves as normal, no explicit instance required.
     - N cancel request stream required: `jobData.Fulfill` must be provided the instance for each stream to fulfill otherwise the safety system will throw an exception.
    
    Note: This is a workaround implementation. #224 will make this cleaner.
    
    This approach can be applied to all write wide (shard write) types. Support will be added in an upcoming commit.
    mbaker3 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7fbfdb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9239df7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    c5aaa91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7c4de8 View commit details
    Browse the repository at this point in the history