Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Burstable ID Provider #258

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Atomic Burstable ID Provider #258

merged 3 commits into from
Jun 6, 2023

Conversation

jkeon
Copy link
Member

@jkeon jkeon commented May 31, 2023

Adding in an IDProvider but that is atomic and burstable allowing for generating ID's in Bursted Jobs and in parallel.

What is the current behaviour?

IDProvider is a class and cannot be used in jobs.

What is the new behaviour?

IDProviderAtomicBurstable is a struct that is Burst Safe and allows the ID to be generated in an atomic fashion so it is also thread safe.

What issues does this resolve?

  • None

What PRs does this depend on?

Does this introduce a breaking change?

  • Yes
  • No

@jkeon jkeon requested a review from mbaker3 May 31, 2023 18:57
@jkeon jkeon mentioned this pull request May 31, 2023
2 tasks
Scripts/Runtime/Data/IDProviderAtomicBurstable.cs Outdated Show resolved Hide resolved
Scripts/Runtime/Data/IDProviderAtomicBurstable.cs Outdated Show resolved Hide resolved
Scripts/Runtime/Data/IDProviderAtomicBurstable.cs Outdated Show resolved Hide resolved
Scripts/Runtime/Data/IDProviderAtomicBurstable.cs Outdated Show resolved Hide resolved
@jkeon jkeon requested a review from mbaker3 June 6, 2023 19:28
Base automatically changed from ecb-internals to main June 6, 2023 19:54
@jkeon jkeon merged commit 571fd7f into main Jun 6, 2023
@jkeon jkeon deleted the atomic-burstable-id-provider branch June 6, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants