-
Notifications
You must be signed in to change notification settings - Fork 1
[feature] Multi-repo workflow #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ranger-X
wants to merge
60
commits into
main
Choose a base branch
from
i-makeev/feature-multirepo-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
8fb624e
* default's `before_script` block in Setup moved to `.setup`, so it's…
Ranger-X d76af77
* add `.lint` job to `lint` stage
Ranger-X 40fdc7e
* add workflow D8.Module
Ranger-X 179c7b0
* revert back to dedicated files instead of workflow, because workflo…
Ranger-X c9d8ddb
* add .publish job to deploy stage
Ranger-X 8d9fccb
fix: remove dependencies: .build from .publish
Ranger-X 7a12eb9
* add Deploy_DEV job
Ranger-X f23c336
* fix .default_rules
Ranger-X e888650
* fix .default_rules
Ranger-X 44afc49
* add jobs/Deploy_PROD
Ranger-X d40fc2e
refactor: move my `multi-repo` version to `templates/multi-repo`
Ranger-X 34cad56
* multi-repo readme and example
Ranger-X 13fb130
* fix URL to templates in `multi-repo-module.gitlab-ci.yml` as it alr…
Ranger-X f3eb923
* add `Publish default branch to DEV` job to `Deploy_DEV`
Ranger-X e13130d
* added `Cleanup` job
Ranger-X 36be3a7
* add cleanup include to `multi-repo` example
Ranger-X d7bf265
* add `Auto cleanup` job which randomly (if current second is divided…
Ranger-X 66f58d1
* fix `auto cleanup` job rules
Ranger-X ac682ef
* allow `auto cleanup` job to fail
Ranger-X f6526e5
* refactor PROD deploy with EDITION and parallel.matrix.RELEASE_CHANNEL
Ranger-X d37be2d
* do not run auto-cleanup when tag defined (release workflow)
Ranger-X faeaae9
* fix .deploy_prod_rules
Ranger-X 615652d
* add deploy to PROD EE
Ranger-X 267b541
* fix .deploy_prod_rules
Ranger-X 96b6368
* dry run deploy jobs (without crane copy)
Ranger-X a60c3e0
* remove 'dry run' mode for deploy to prod
Ranger-X 1105f86
* add description to variables
Ranger-X dea5cea
* fix FORCE_CI conditions
Ranger-X b9fffe1
* debug Build/deploy
Ranger-X dfdd145
* fix deploy
Ranger-X b30ef21
* add Deploy_PROD_experiment
Ranger-X 7112660
* Deploy_PROD_experiment
Ranger-X 4bbf96f
* fix Deploy_PROD_experiment
Ranger-X 4ee3f68
* fix Deploy_PROD_experiment
Ranger-X 3657f8f
* fix Deploy_PROD_experiment
Ranger-X 6d3ea5f
* add inputs.editions to Deploy_PROD
Ranger-X 9ac105f
* add spec.inputs.editions to README.md
Ranger-X 61df342
* remove `if: $CI_COMMIT_BRANCH` rule from .default_rules
Ranger-X b1411a5
* add debug job
Ranger-X e6a7292
* fix `debug:printenv`
Ranger-X c40f9e9
[.default_rules] fix: do not run pipeline for push to the branch
Ranger-X 40a8669
[.default_rules] fix: run when merge request is merged to main/master…
Ranger-X e04f697
[Publish merge request to DEV] fix: run
Ranger-X 49158da
[Publish merge request to DEV] fix: run when new branch is created an…
Ranger-X cb2e7b6
[Publish merge request to DEV] fix: run when new branch is created an…
Ranger-X 7b05506
* remove pipeline rule for "new branches"
Ranger-X 342b777
* automatically create gitlab release when push new tag
Ranger-X 56a6489
[Create gitlab release] * fix
Ranger-X b18b4ad
* remove release creating
Ranger-X 7e3d048
* remove release creating
Ranger-X 321ec8c
[.publish] fix: copy to destination registry only final images from `…
Ranger-X b0b284e
* set timeout for `Auto cleanup` job to 10 minutes instead of default…
Ranger-X eec1b1d
* print env vars on .deploy_prod if DEBUG_CI enabled
Ranger-X 00112da
* grouping deploy jobs by release channels
Ranger-X 2e963f5
* slightly rename deploy jobs: move env suffix (DEV/PROD) to begin of…
Ranger-X 89dd366
* slightly rename deploy jobs
Ranger-X c92fc2d
* slightly rename deploy jobs
Ranger-X 61fee16
* slightly rename deploy jobs
Ranger-X 9d381c3
* do not download base_images.yml if BASE_IMAGES_VERSION is empty
Ranger-X 1accb07
* use BASE_IMAGES_VERSION v0.5.2
Ranger-X File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
include: | ||
- remote: 'https://raw.githubusercontent.com/deckhouse/modules-gitlab-ci/refs/heads/main/templates/multi-repo/Setup.gitlab-ci.yml' | ||
- remote: 'https://raw.githubusercontent.com/deckhouse/modules-gitlab-ci/refs/heads/main/templates/multi-repo/Lint.gitlab-ci.yml' | ||
- remote: 'https://raw.githubusercontent.com/deckhouse/modules-gitlab-ci/refs/heads/main/templates/multi-repo/Build.gitlab-ci.yml' | ||
- remote: 'https://raw.githubusercontent.com/deckhouse/modules-gitlab-ci/refs/heads/main/templates/multi-repo/Deploy.gitlab-ci.yml' | ||
- remote: 'https://raw.githubusercontent.com/deckhouse/modules-gitlab-ci/refs/heads/main/templates/multi-repo/Cleanup.gitlab-ci.yml' | ||
# deploy jobs for DEV registry | ||
- remote: 'https://raw.githubusercontent.com/deckhouse/modules-gitlab-ci/refs/heads/main/jobs/multi-repo/Deploy_DEV.gitlab-ci.yml' | ||
# deploy jobs for PROD registry | ||
- remote: 'https://raw.githubusercontent.com/deckhouse/modules-gitlab-ci/refs/heads/main/jobs/multi-repo/Deploy_PROD.gitlab-ci.yml' | ||
inputs: | ||
# Editions used in your module. Array of following items: | ||
# ce - Community edition | ||
# ee - Enterprise edition | ||
# fe - Flant edition (internal edition for Flant's engineers) | ||
# se - Standard edition | ||
# se-plus - Standard edition + | ||
editions: | ||
# All values must be in lowercase and quoted | ||
- "ce" | ||
- "ee" | ||
- "fe" | ||
- "se" | ||
- "se-plus" | ||
|
||
variables: | ||
# Do not forget to put these variables to your Gitlab CI secrets: | ||
# They are REQUIRED and used for pulling/pushing images to the corresponding registry | ||
# - DEV_MODULES_REGISTRY: DEV registry domain (like: registry.example.com) | ||
# - DEV_MODULES_REGISTRY_PATH: path to modules repository in DEV registry (like: deckhouse/modules) | ||
# - DEV_MODULES_REGISTRY_LOGIN: username to log in to DEV registry | ||
# - DEV_MODULES_REGISTRY_PASSWORD: password to log in to DEV registry | ||
|
||
# WARNING: If some of following variables are NOT SET, then there is NO production deployment jobs will be created in pipeline | ||
# - PROD_MODULES_REGISTRY: PROD registry domain (like: registry.example.com) | ||
# - PROD_MODULES_REGISTRY_PATH: path to modules repository in PROD registry (like: deckhouse/modules) | ||
# - PROD_MODULES_REGISTRY_LOGIN: username to log in to PROD registry | ||
# - PROD_MODULES_REGISTRY_PASSWORD: password to log in to PROD registry | ||
WERF_VERSION: "2 stable" | ||
BASE_IMAGES_VERSION: v0.2 | ||
|
||
default: | ||
tags: | ||
- my-runner-tag | ||
|
||
|
||
###### LINT STAGE ###### | ||
|
||
Lint: | ||
extends: .lint | ||
|
||
###### END OF LINT STAGE ###### | ||
|
||
###### BUILD STAGE ###### | ||
|
||
Build: | ||
extends: .build | ||
|
||
###### END OF BUILD STAGE ###### |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
variables: | ||
DEBUG_CI: | ||
value: "false" | ||
description: "Run debug job(s)" | ||
|
||
debug:printenv: | ||
stage: build | ||
rules: | ||
# run if $DEBUG_CI variable is set to true | ||
- if: $DEBUG_CI == "true" || $DEBUG_CI == "1" | ||
script: | ||
- | | ||
printenv | sort |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# emulate same behaviour as in Deckhouse Github registry | ||
# when opened PRs will pushed to dev registry | ||
DEV | Publish merge request: | ||
extends: .publish | ||
variables: | ||
MODULES_REGISTRY: ${DEV_MODULES_REGISTRY} | ||
MODULES_REGISTRY_PATH: ${DEV_MODULES_REGISTRY_PATH} | ||
MODULES_REGISTRY_LOGIN: ${DEV_MODULES_REGISTRY_LOGIN} | ||
MODULES_REGISTRY_PASSWORD: ${DEV_MODULES_REGISTRY_PASSWORD} | ||
# names as in Github: "pr" + merge request project-level ID instead of branch name | ||
MODULES_MODULE_TAG: pr${CI_MERGE_REQUEST_IID} | ||
rules: | ||
# do not run if some required variables is empty | ||
- if: '$DEV_MODULES_REGISTRY == null || $DEV_MODULES_REGISTRY == "" || $DEV_MODULES_REGISTRY_PATH == null || $DEV_MODULES_REGISTRY_PATH == ""' | ||
when: never | ||
# run only for merge requests | ||
- if: $CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_SOURCE_BRANCH_NAME != $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "merge_request_event" | ||
when: on_success | ||
# run when new branch is created and there are no opened merge requests for this branch and no commits to this branch yet (completely new branch from master/main) | ||
# - if: $CI_COMMIT_BRANCH != $CI_DEFAULT_BRANCH && ($CI_MERGE_REQUEST_IID == null || $CI_MERGE_REQUEST_IID == "") && $CI_COMMIT_BEFORE_SHA == "0000000000000000000000000000000000000000" | ||
# when: on_success | ||
# do not run in other cases | ||
- when: never | ||
|
||
DEV | Publish default branch: | ||
extends: .publish | ||
variables: | ||
MODULES_REGISTRY: ${DEV_MODULES_REGISTRY} | ||
MODULES_REGISTRY_PATH: ${DEV_MODULES_REGISTRY_PATH} | ||
MODULES_REGISTRY_LOGIN: ${DEV_MODULES_REGISTRY_LOGIN} | ||
MODULES_REGISTRY_PASSWORD: ${DEV_MODULES_REGISTRY_PASSWORD} | ||
MODULES_MODULE_TAG: ${CI_DEFAULT_BRANCH} | ||
rules: | ||
# do not run if some required variables is empty | ||
- if: '$DEV_MODULES_REGISTRY == null || $DEV_MODULES_REGISTRY == "" || $DEV_MODULES_REGISTRY_PATH == null || $DEV_MODULES_REGISTRY_PATH == ""' | ||
when: never | ||
# run only when push to default (main/master) branch | ||
- if: $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH | ||
when: on_success | ||
# do not run in other cases | ||
- when: never |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# https://docs.gitlab.com/ci/inputs/ | ||
spec: | ||
inputs: | ||
editions: | ||
type: array | ||
description: List of module editions | ||
default: | ||
- ee | ||
- fe | ||
- se | ||
- se-plus | ||
|
||
--- | ||
|
||
PROD | Alpha: | ||
extends: .deploy_prod | ||
variables: | ||
RELEASE_CHANNEL: alpha | ||
parallel: | ||
matrix: | ||
- EDITION: $[[ inputs.editions ]] | ||
|
||
PROD | Beta: | ||
extends: .deploy_prod | ||
variables: | ||
RELEASE_CHANNEL: beta | ||
parallel: | ||
matrix: | ||
- EDITION: $[[ inputs.editions ]] | ||
|
||
PROD | EarlyAccess: | ||
extends: .deploy_prod | ||
variables: | ||
RELEASE_CHANNEL: early-access | ||
parallel: | ||
matrix: | ||
- EDITION: $[[ inputs.editions ]] | ||
|
||
PROD | Stable: | ||
extends: .deploy_prod | ||
variables: | ||
RELEASE_CHANNEL: stable | ||
parallel: | ||
matrix: | ||
- EDITION: $[[ inputs.editions ]] | ||
|
||
# because uppercased letters are ordered before lowercased, so put rock-solid job last as in stability level, not alphabetical | ||
PROD | rock-solid: | ||
extends: .deploy_prod | ||
variables: | ||
RELEASE_CHANNEL: rock-solid | ||
parallel: | ||
matrix: | ||
- EDITION: $[[ inputs.editions ]] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,4 +43,4 @@ | |
--new_tag "${MODULES_MODULE_SOURCE}:${MODULES_MODULE_NAME}" | ||
only: | ||
- tags | ||
- branches | ||
- branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
.build: | ||
stage: build | ||
rules: | ||
- !reference [.default_rules, rules] | ||
before_script: | ||
- !reference [.setup, before_script] | ||
script: | ||
# Build images | ||
- | | ||
werf build \ | ||
--save-build-report --build-report-path images_tags_werf.json | ||
artifacts: | ||
paths: | ||
- images_tags_werf.json | ||
expire_in: "30 days" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
Scheduled cleanup: | ||
stage: cleanup | ||
rules: | ||
- if: $CI_PIPELINE_SOURCE == "schedule" | ||
when: on_success | ||
- when: never | ||
before_script: | ||
- !reference [.setup, before_script] | ||
script: | ||
- werf managed-images ls | ||
- werf cleanup | ||
|
||
Auto cleanup: | ||
stage: cleanup | ||
allow_failure: true | ||
timeout: 10 minutes | ||
rules: | ||
# do not run if this job is explicitly disabled by user | ||
- if: $AUTO_CLEANUP == "false" || $AUTO_CLEANUP == "0" || $AUTO_CLEANUP == "" | ||
when: never | ||
# do not run if there is a tag (release workflow) | ||
- if: $CI_COMMIT_TAG | ||
when: never | ||
- !reference [.default_rules, rules] | ||
before_script: | ||
- !reference [.setup, before_script] | ||
script: | ||
- | | ||
if (( $(date +%s) % 10 == 0 )); then | ||
echo "✨ Run auto cleanup" | ||
werf managed-images ls | ||
werf cleanup | ||
fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
.publish: | ||
stage: deploy | ||
script: | ||
- | | ||
# Login to Gitlab (source) registry if target registry is not same Gitlab | ||
if [[ "x${MODULES_REGISTRY}" != "x${CI_REGISTRY}" ]]; then | ||
echo "Login to Gitlab (source) ${CI_REGISTRY}..." | ||
werf cr login -u ${CI_REGISTRY_USER} -p ${CI_REGISTRY_PASSWORD} ${CI_REGISTRY} | ||
fi | ||
|
||
# Login to target registry | ||
werf cr login -u ${MODULES_REGISTRY_LOGIN} -p ${MODULES_REGISTRY_PASSWORD} ${MODULES_REGISTRY} | ||
# generate MODULES_MODULE_SOURCE | ||
- | | ||
export MODULES_MODULE_SOURCE="${MODULES_REGISTRY}/${MODULES_REGISTRY_PATH}" | ||
|
||
# Module images | ||
- | | ||
jq -r '.Images | values[] | select (.Final==true) | .WerfImageName + " " + .DockerImageName + " " + .DockerTag + " " + .DockerImageDigest' < images_tags_werf.json | while read line; do | ||
image="$(cut -d " " -f 1 <<< ${line})" | ||
docker_image="$(cut -d " " -f 2 <<< ${line})" | ||
docker_tag="$(cut -d " " -f 3 <<< ${line})" | ||
shasum="$(cut -d " " -f 4 <<< ${line})" | ||
name="$(tr '[:lower:]' '[:upper:]' <<< ${image} | sed 's|[-/]|_|g')" | ||
|
||
# image: pg-images-17.3-bookworm-standard; | ||
# name: PG_IMAGES_17.3_BOOKWORM_STANDARD; | ||
# shasum: sha256:cd6daa30c94ec77b352156cbf1c05c8e98b44d1d3a47fa2b0a1083587247f730; | ||
# docker_image: registry.flant.com/team/managed-services/managed-psql/managed-psql-d8/managed-postgres:ed0388a743d61926309d1023e02c639c1006f7b7b56d78161f32b0e0-1744971955188; | ||
# docker_tag: ed0388a743d61926309d1023e02c639c1006f7b7b56d78161f32b0e0-1744971955188 | ||
|
||
IMAGE_SRC="${docker_image}" | ||
IMAGE_DST="${MODULES_MODULE_SOURCE}/${MODULES_MODULE_NAME}:${docker_tag}" | ||
|
||
echo "✨ Pushing ${IMAGE_SRC} to ${IMAGE_DST}" | ||
crane copy ${IMAGE_SRC} ${IMAGE_DST} | ||
done | ||
|
||
# Bundle image | ||
- | | ||
IMAGE_SRC="$(jq -r '.Images."bundle".DockerImageName' images_tags_werf.json)" | ||
IMAGE_DST="${MODULES_MODULE_SOURCE}/${MODULES_MODULE_NAME}:${MODULES_MODULE_TAG}" | ||
|
||
echo "✨ Pushing BUNDLE ${IMAGE_SRC} to ${IMAGE_DST}" | ||
crane copy ${IMAGE_SRC} ${IMAGE_DST} | ||
# Release-channel image | ||
- | | ||
IMAGE_SRC="$(jq -r '.Images."release-channel-version".DockerImageName' images_tags_werf.json)" | ||
IMAGE_DST="${MODULES_MODULE_SOURCE}/${MODULES_MODULE_NAME}/release:${MODULES_MODULE_TAG}" | ||
|
||
echo "✨ Pushing RELEASE ${IMAGE_SRC} to ${IMAGE_DST}" | ||
crane copy ${IMAGE_SRC} ${IMAGE_DST} | ||
# Register module | ||
- | | ||
echo "✨ Register the module ${MODULES_MODULE_NAME}" | ||
crane append \ | ||
--oci-empty-base \ | ||
--new_layer "" \ | ||
--new_tag "${MODULES_MODULE_SOURCE}:${MODULES_MODULE_NAME}" | ||
|
||
.deploy: | ||
stage: deploy | ||
script: | ||
- | | ||
REPO="${MODULES_REGISTRY}/${MODULES_REGISTRY_PATH}/${MODULES_MODULE_NAME}/release" | ||
|
||
IMAGE_SRC="${REPO}:${MODULES_MODULE_TAG}" | ||
IMAGE_DST="${REPO}:${RELEASE_CHANNEL}" | ||
|
||
echo "✨ Pushing ${IMAGE_SRC} to ${IMAGE_DST}" | ||
crane copy "${IMAGE_SRC}" "${IMAGE_DST}" | ||
|
||
.deploy_prod_rules: | ||
rules: | ||
# add MANUAL deploy job if $FORCE_CI variable is set | ||
- if: $FORCE_CI == "true" || $FORCE_CI == "1" | ||
when: manual | ||
# do not run if some required variables is empty | ||
- if: '$PROD_MODULES_REGISTRY == null || $PROD_MODULES_REGISTRY == "" || $EDITION == null || $EDITION == "" || $RELEASE_CHANNEL == null || $RELEASE_CHANNEL == ""' | ||
when: never | ||
# add MANUAL deploy job only if it is a tag defined (release workflow) | ||
- if: '$CI_COMMIT_TAG' | ||
when: manual | ||
|
||
.deploy_prod: | ||
stage: deploy | ||
rules: | ||
- !reference [.deploy_prod_rules, rules] | ||
variables: | ||
MODULES_REGISTRY: $PROD_MODULES_REGISTRY | ||
MODULES_REGISTRY_LOGIN: $PROD_MODULES_REGISTRY_LOGIN | ||
MODULES_REGISTRY_PASSWORD: $PROD_MODULES_REGISTRY_PASSWORD | ||
# path in PROD registry must be hardcoded | ||
MODULES_REGISTRY_PATH: deckhouse/${EDITION}/modules | ||
script: | ||
- | | ||
if [ "$DEBUG_CI" = "true" -o "$DEBUG_CI" = "1" ]; then | ||
printenv | sort | ||
fi | ||
# publish final images to prod registry and register module with $MODULES_MODULE_TAG | ||
- !reference [.publish, script] | ||
# make 'symlink' to published module tag for specified release-channel | ||
- !reference [.deploy, script] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only
,when
andrules
don't work well together. If we implement rules, then it's better to get rid ofwhen
withoutrules
in the job andonly
in these jobs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
multi-repo
templates (templates/multi-repo/*.yml
) I userules
everywhere. Do you mean get rid ofonly
insimple
templates (templates/*.yml
)?