Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings from SASS #13199

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

There are some deprecation warnings when building the assets that come from a change in SASS syntax:

DEPRECATION WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

This PR fixes those error messages. The only deprecation warnings left are from tom-select, it was reported in this issue: orchidjs/tom-select#742

Testing

Run rm -rf public/decidim-packs/ ; bin/rails assets:precompile and see the output (before and after this patch)

♥️ Thank you!

@andreslucena andreslucena added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Jul 23, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Checked the pipeline output. The only deprecation warnings were related to tom-select.

@alecslupu alecslupu added this to the 0.30.0 milestone Jul 23, 2024
@alecslupu alecslupu merged commit 935bf30 into develop Jul 23, 2024
111 of 112 checks passed
@alecslupu alecslupu deleted the chore/sass-deprecation-warnings branch July 23, 2024 17:51
@alecslupu
Copy link
Contributor

@andreslucena , maybe we can set the type to fix, so that we can backport it to 0.29 ?

@andreslucena andreslucena added type: fix PRs that implement a fix for a bug and removed type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jul 31, 2024
@andreslucena
Copy link
Member Author

@andreslucena , maybe we can set the type to fix, so that we can backport it to 0.29 ?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: core type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants