Support LTV and Timestamp #70

hidasw · 2024-04-24T09:19:20Z

Add Support for Long Term Validation and Timestamping.
Also skip tempfile requirement at signing process to improve performance and efficiency.

Add last parameter for chain certs

And improve signature process . no need to write/read/parse tempfile in signing process.

parallels999 · 2024-04-24T14:43:49Z

test/signed_1.pdf

All these files inside the test folder are necessary or did you forget to add an entry in the .gitignore file??

Also signature.log?

all pdf is test result, no needed. will be removed.
signature.log no need here, only created in signing process.
you can disable it by set cms->writeLog to false

parallels999 · 2024-04-24T14:45:56Z

pdfsign.php

@@ -18,39 +18,55 @@
    You should have received a copy of the GNU Lesser General Public License
    along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-
+echo "<pre>";


Is this html? or does it perform other functionality? really, I don't know, it's curiosity

This example changed a lot, it is no longer consistent with the others

this is html in webserver because currently i'm using windows. so no stty command.
next i'll try to use stty in windows, maybe via msys2.

Just add a .bat, that would add support for windows, look at https://github.com/dealfonso/sapp/pull/52/files

https://github.com/dealfonso/sapp/blob/24eee11992dffee0077cc983d727ebb8f50950b3/stty.bat

yes i've got it. Thanks

src/PDFDoc.php

parallels999 · 2024-04-24T22:42:56Z

pdfsign.php


-if ($argc !== 3)
-    fwrite(STDERR, sprintf("usage: %s <filename> <certfile>", $argv[0]));


These examples are designed to be scripts executable by console, you execute them by sending the arguments, with this change only pre-established files are used

Look at this:

sapp/pdfsignt.php

Lines 39 to 40 in 24eee11

// Silently prompt for the timestamp autority

fwrite(STDERR, "TSA(\"http://timestamp.digicert.com\"): ");

i have changed that. please check it

Do you need help??

sure, of course.

remove logging function, use sapp default logging function

dealfonso · 2024-04-26T11:09:51Z

this PR looks great! thank you for your work!

@parallels999 have you tried it?

parallels999 · 2024-04-26T14:22:04Z

src/helpers/asn1.php

- */
-namespace ddn\sapp\helpers;
-
-class asn1 {


Originally the classes had individual files, I don't know why you unified everything in a single file

sorry about that. as I said, I'm not so familiar with namespaces and class autoload.

migrate asn1 class functions to dynamic functions

dealfonso

please, remove the files in the examples folder

examples/PDF User.chain.pfx

examples/PDF User.nochain.pfx

examples/Root CA Test.crt

examples/RootCATest.der.crl

pdfsign.php

parallels999 · 2024-05-02T13:57:29Z

src/helpers/asn1.php

+  }
+  // =====End ASN.1 Builder section=====
+}
+?>


Just a suggestion, in PHP you don't need to close when it's just a class file, you only need to leave a line break as end of file
This does not affect the code in any way, it is just a standard (it seems to me)

-?> +

Thanks. And does it also apply to bracket for if else in eg: pdfsign.php?
sometime its makes me confusing to find the boundary.

-change some message text. -set default $ocspUrl & $crl to prevent php notice message append in pdf result

Small fixes

calculated __SIGNATURE_MAX_LENGTH exactly. no longer waste signature space with zero padding.

- support path validation (unlimited) - removed ocsp, crl and issuer parameter (because it is difficult to implement if the certificate has a long path)

hidasw · 2024-05-14T17:15:59Z

I'm also interested if we can define signature max length before signing

Those optimizations would be better in a separate PR

i have updated, but already implement that. feel free to change/remove if it needless.

erikn69 · 2024-05-14T17:20:50Z

merged pdfsignltv.php & pdfsigntsa.php

I actually went to the trouble of separating it for a good reason.
They can be used separately, That's why I created examples for each one.
and in this way you can no longer send arguments to LTV

hidasw · 2024-05-14T17:28:16Z

@erikn69 I think with single merged script we can add or pass tsa. just set tsa url parameter to empty to bypass it? cmiiw..

erikn69 · 2024-05-14T17:32:43Z

?: "http://timestamp.digicert.com";
you removed the default value, but on the text shows digicert as default

erikn69@ac6ae19

hidasw · 2024-05-14T17:33:12Z

merged pdfsignltv.php & pdfsigntsa.php

I actually went to the trouble of separating it for a good reason. They can be used separately, That's why I created examples for each one. and in this way you can no longer send arguments to LTV

also because i have removed optional ltv arguments such ocsp, crl & issuer, because it is difficult to implement if the certificate has a long path. except these arguments refer to a path containts many crl & issuer cert, so the script will search in it.

erikn69 · 2024-05-14T17:34:23Z

The idea of the example scripts is to show a specific functionality, not to add them as a group.

For example, if I want to test TSA, it immediately adds LTV to me

But @dealfonso decides 👍

hidasw · 2024-05-14T17:36:56Z

?: "http://timestamp.digicert.com"; you removed the default value, but on the text shows digicert as default

erikn69@ac6ae19

I don't want to remove remove default value, but how to bypass timestamping without removing that? any idea?

Support <extracerts.pem> on array

erikn69 · 2024-05-14T17:43:26Z

but how to bypass timestamping without removing that? any idea?

That's why I created 2 separate scripts,
but let's leave it like this, this does not affect the functionality

hidasw · 2024-05-14T17:55:42Z

but how to bypass timestamping without removing that? any idea?

That's why I created 2 separate scripts, but let's leave it like this, this does not affect the functionality

umm i just remember that my reason to merged is when we need to perform ltv+timestamping. before merged i can do just timestamp only or ltv only. And to append timestamp token to existing signature we need to signing again caused message digest has changed.

pdfsigntsa.php

dealfonso · 2024-07-13T11:37:07Z

Great job and thank you for the new features!!

hidasw added 9 commits March 20, 2024 22:47

first update to support timestamp

2aac1ea

Add last parameter for chain certs

9df350f

Add last parameter for chain certs

Add last parameter for support chain certs

5cbcc75

expand length to embedded tsa

4bee7a5

update

4fddfe2

add ltv and timestamp

3bb6cf5

Support Timestamp and LTV

2d472a6

And improve signature process . no need to write/read/parse tempfile in signing process.

Update PDFDoc.php

bb1e67b

Update PDFDoc.php

89a507b

parallels999 reviewed Apr 24, 2024

View reviewed changes

src/PDFDoc.php Show resolved Hide resolved

parallels999 reviewed Apr 24, 2024

View reviewed changes

hidasw added 6 commits April 25, 2024 06:15

Update pdfsign.php

ea2b02a

Update CMS.php

deecf48

removed ex test and ex log

b1d0c14

Update PDFDoc.php

cfca51e

Update PDFUtilFnc.php

20580af

Update CMS.php

7313718

remove logging function, use sapp default logging function

parallels999 reviewed Apr 26, 2024

View reviewed changes

hidasw added 2 commits April 30, 2024 13:36

aligned classes structure

6206d16

migrate asn1 class functions to dynamic functions

Merge branch 'dealfonso:main' into main

e90f0ec

dealfonso requested changes May 2, 2024

View reviewed changes

parallels999 reviewed May 2, 2024

View reviewed changes

hidasw closed this May 2, 2024

hidasw force-pushed the main branch from e90f0ec to 5690e90 Compare May 2, 2024 16:30

hidasw added 3 commits May 2, 2024 23:31

Merge branch 'main' of https://github.com/hidasw/sapp

eefb571

remove example

fb66775

Update pdfsign.php

8309b91

-change some message text. -set default $ocspUrl & $crl to prevent php notice message append in pdf result

erikn69 and others added 7 commits May 9, 2024 13:24

Small fixes

303149d

Merge pull request #2 from erikn69/patch-7

f993e54

Small fixes

calculate __SIGNATURE_MAX_LENGTH

1fea292

calculated __SIGNATURE_MAX_LENGTH exactly. no longer waste signature space with zero padding.

merged pdfsignltv.php & pdfsigntsa.php

6b263ad

Update CMS.php

a9ddbbb

- support path validation (unlimited) - removed ocsp, crl and issuer parameter (because it is difficult to implement if the certificate has a long path)

merged

eb5bd7a

Support <extracerts.pem>

08e622b

Merge pull request #3 from erikn69/patch-8

dab191c

Support <extracerts.pem> on array

hidasw added 3 commits May 15, 2024 01:10

Update pdfsignlts.php

56a2ffe

Create pdfsigntsa.php

074fb1a

Merge branch 'main' of https://github.com/hidasw/sapp

3fb1d74

hidasw commented May 14, 2024

View reviewed changes

pdfsigntsa.php Outdated Show resolved Hide resolved

hidasw and others added 3 commits May 15, 2024 02:00

Update asn1.php

f73e9fd

minor bugs

453d3f2

minor bugs

2cdf41b

dealfonso approved these changes Jul 13, 2024

View reviewed changes

dealfonso merged commit 37ff265 into dealfonso:main Jul 13, 2024

This was referenced Jul 13, 2024

Adds support for intermediate certificates in PDF document signing #61

Closed

LTV and timestamp #8

Closed

parallels999 mentioned this pull request Jul 23, 2024

Using TSA causes a extra xref size #77

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support LTV and Timestamp #70

Support LTV and Timestamp #70

hidasw commented Apr 24, 2024

parallels999 Apr 24, 2024 •

edited

Loading

hidasw Apr 24, 2024

parallels999 Apr 24, 2024

hidasw Apr 24, 2024

parallels999 Apr 24, 2024 •

edited

Loading

hidasw Apr 24, 2024

parallels999 Apr 24, 2024 •

edited

Loading

hidasw Apr 24, 2024

hidasw Apr 26, 2024

dealfonso commented Apr 26, 2024

parallels999 Apr 26, 2024

hidasw Apr 27, 2024

dealfonso left a comment

parallels999 May 2, 2024

hidasw May 2, 2024

hidasw commented May 14, 2024

erikn69 commented May 14, 2024

hidasw commented May 14, 2024

erikn69 commented May 14, 2024

hidasw commented May 14, 2024

erikn69 commented May 14, 2024 •

edited

Loading

hidasw commented May 14, 2024

erikn69 commented May 14, 2024

hidasw commented May 14, 2024

dealfonso commented Jul 13, 2024


		if ($argc !== 3)
		fwrite(STDERR, sprintf("usage: %s <filename> <certfile>", $argv[0]));

	// Silently prompt for the timestamp autority
	fwrite(STDERR, "TSA(\"http://timestamp.digicert.com\"): ");

Support LTV and Timestamp #70

Support LTV and Timestamp #70

Conversation

hidasw commented Apr 24, 2024

parallels999 Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parallels999 Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parallels999 Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dealfonso commented Apr 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dealfonso left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hidasw commented May 14, 2024

erikn69 commented May 14, 2024

hidasw commented May 14, 2024

erikn69 commented May 14, 2024

hidasw commented May 14, 2024

erikn69 commented May 14, 2024 • edited Loading

hidasw commented May 14, 2024

erikn69 commented May 14, 2024

hidasw commented May 14, 2024

dealfonso commented Jul 13, 2024

parallels999 Apr 24, 2024 •

edited

Loading

parallels999 Apr 24, 2024 •

edited

Loading

parallels999 Apr 24, 2024 •

edited

Loading

erikn69 commented May 14, 2024 •

edited

Loading