-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
used shellcheck, some fixes, added new countries, added new support for url query parameter #10
Open
YoshiMan
wants to merge
7
commits into
deadhead420:master
Choose a base branch
from
YoshiMan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 20, 2017
-
used shellcheck to find issues.
https://github.com/koalaman/shellcheck fixed SC2128: Expanding an array without an index only gives the first element. https://github.com/koalaman/shellcheck/wiki/SC2128
Configuration menu - View commit details
-
Copy full SHA for 711f45c - Browse repository at this point
Copy the full SHA 711f45cView commit details
Commits on Nov 22, 2017
-
used shellcheck to find issues.
https://github.com/koalaman/shellcheck fixed SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo' https://github.com/koalaman/shellcheck/wiki/SC2116 query, code and country variable to an array changed case statement
Configuration menu - View commit details
-
Copy full SHA for 9bcb286 - Browse repository at this point
Copy the full SHA 9bcb286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64fab46 - Browse repository at this point
Copy the full SHA 64fab46View commit details -
fixed SC2162: read without -r will mangle backslashes. https://github.com/koalaman/shellcheck/wiki/SC2162
Configuration menu - View commit details
-
Copy full SHA for 6826b27 - Browse repository at this point
Copy the full SHA 6826b27View commit details -
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. https://github.com/koalaman/shellcheck/wiki/SC2181
Configuration menu - View commit details
-
Copy full SHA for 8a9f295 - Browse repository at this point
Copy the full SHA 8a9f295View commit details
Commits on Nov 27, 2017
-
added support for 'protocol' parameter
added support for 'ip_version' parameter added support for 'use_mirror_status' parameter
Configuration menu - View commit details
-
Copy full SHA for 4e8540e - Browse repository at this point
Copy the full SHA 4e8540eView commit details
Commits on Nov 29, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 057a848 - Browse repository at this point
Copy the full SHA 057a848View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.