feat: update version detection to support ddev head version #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkibaAT
force-pushed
the
feature/support-ddev-head-version
branch
from
5b1e6ae to
af118ed
Compare
AkibaAT
force-pushed
the
feature/support-ddev-head-version
branch
from
af118ed to
10cadfe
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Currently, ddev head versions that report a version like
ddev version v1.24.4-36-ge74e3a95fare not supported by the plugin.How this PR Solves the Problem:
Updated the version parsing to handle head versions.
Manual Testing Instructions:
Download a DDEV head version: https://ddev.readthedocs.io/en/stable/developers/building-contributing/#testing-latest-commits-on-head
Change the DDEV settings in PhpStorm to use the head version path (/usr/local/bin/ddev)
Check if the plugin still works
Related Issue Link(s):