Open
Conversation
Feature/match addon template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
Some environments do not allow site developers to save data to the root of the project. For instance, multisite environments on a common Drupal deployment where each site developer can only maintains the code within their site folder (e.g.
web/sites/my.site.com.Additionally, this will address some naming mismatches throughout the add-on (backstop, backstopjs, ddev-backstopjs, etc.)
How This PR Solves The Issue
Using ddev's environment variables for containers, the custom tests path can be saved to the project and updates from this add-on can still be consumed without revisiting configuration. This also allows the developer to save their backstop data to a custom place and still be able to share it with their team.
Manual Testing Instructions
ddev add-on get https://github.com/mmunz/ddev-backstopjs/tarball/refs/pull/27/head ddev restart ddev backstop init ddev backstop reference ddev backstop test ddev backstop-resultsddev backstop init ddev backstop reference ddev backstop test ddev backstop-results