Apply suggestions from code review

ddelange · Jun 26, 2024 · 65fb61c · 65fb61c
1 parent 3a55538
commit 65fb61c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,7 +19,8 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
           allow-prereleases: true
-      - run: ${{ ( startsWith( matrix.os, 'windows' ) && 'bash add_libmagic.sh' ) || 'sudo -E bash add_libmagic.sh' }}
+      - name: Copy libmagic into magic dir
+        run: ${{ ( startsWith( matrix.os, 'windows' ) && 'bash add_libmagic.sh' ) || 'sudo -E bash add_libmagic.sh' }}
       - run: pip install --upgrade pip
       - run: pip install --upgrade pytest
       - run: pip install --editable .

diff --git a/README.md b/README.md
@@ -70,7 +70,7 @@ apt-get update && apt-get install -y libmagic1
 # Alpine
 apk add --update libmagic
 # RHEL
-yum install file-libs
+dnf install file-libs
 ```
 
 ### Windows