DCOS-1521 Fix OAuth wording #192
Conversation
|
@mgummelt Let me know what you think. |
| emitter.publish(errors.DefaultError( | ||
| '{message}\n\n {url}\n\n'.format(message=message, | ||
| url=auth_url,))) | ||
| emitter.publish( |
There was a problem hiding this comment.
we haven't been using named parameters in string interpolation. I know you didn't write this, but can you change it?
There was a problem hiding this comment.
also, why are we printing this to stderr?
There was a problem hiding this comment.
also, why are we printing this to stderr?
A principal that we try to keep in the dcos cli is that stdout should have a predictable output that is pipe-able to a program. E.g. grep, jq, etc.
Let say that you want to: dcos marathon app list | ... if we the above message is written to stdout then the pipe is probably incorrect. In those cases we try to print those messages to stderr.
There was a problem hiding this comment.
haven't been using named parameters in string interpolation. I know you didn't write this, but can you change it?
Done.
|
Some simple stuff then LGTM |
jsancio
force-pushed
the
dcos-1521-fix-oauth-wording
branch
from
7fe6d0f to
afea6f8
Compare
|
|
||
| code = moves.input('Please enter Mesosphere verification code: ').strip() |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
No description provided.