Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster dc.filterAll() #1323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Faster dc.filterAll() #1323

wants to merge 2 commits into from

Conversation

ehansis
Copy link

@ehansis ehansis commented Jul 24, 2017

Fixes #1322

@gordonwoodhull
Copy link
Contributor

This looks good to me, but why is it necessary to call .filter(0) on all of those charts in the tests?

@ehansis
Copy link
Author

ehansis commented Jul 25, 2017

In charts w/ grouping, the tests check that chart.filterAll() is called or not called on a chart depending on its chart group. Since the modified dc.filterAll() only calls chart.filterAll() on charts that have a filter set, we need to set a filter on each chart to do a meaningful test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehansis @gordonwoodhull