deselect as well as select when applying filters

here is another thing that should be tested (re: #1019)
dc-js · Oct 2, 2015 · d9be022 · d9be022
1 parent c85c101
commit d9be022
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/select-menu.js b/src/select-menu.js
@@ -63,10 +63,9 @@ dc.selectMenu = function (parent, chartGroup) {
         // select the option(s) corresponding to current filter(s)
         if (_chart.hasFilter() && _multiple) {
             _select.selectAll('option')
-                .filter(function (d) {
+                .property('selected', function (d) {
                     return d && _chart.filters().indexOf(String(_chart.keyAccessor()(d))) >= 0;
-                })
-                .property('selected', true);
+                });
         } else if (_chart.hasFilter()) {
             _select.property('value', _chart.filter());
         } else {