Make sure we request a response when writing to a GATT characteristic #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really? No change needed in esphome? |
|
Thanks, I will possibly open a PR with more thorough |
|
Should I merge it to a branch and make a beta release? |
|
This way others can start testing too :) |
|
Sure, let's go |
Merged
dbuezas
added a commit
that referenced
this pull request
Jan 26, 2023
…#37) (#42) Co-authored-by: Petko Bordjukov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Feedback more than welcome. Maybe this parameter should be extracted as an argument of
async_make_requestand not be hardcoded? Opinions?