Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constraints.md #3736

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Update constraints.md #3736

merged 4 commits into from
Aug 11, 2023

Conversation

runleonarun
Copy link
Collaborator

resolves #3454

What are you changing in this pull request and why?

Adding an example of column level constraints for BigQuery only.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@runleonarun runleonarun requested a review from a team as a code owner July 13, 2023 19:54
@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs labels Jul 13, 2023
@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 8ab7453
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64d66c15bfb13a00081472e5
😎 Deploy Preview https://deploy-preview-3736--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the size: medium This change will take up to a week to address label Jul 13, 2023
}}

select
'string' as a,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this example were more "real world" but this gets the point across.

@runleonarun runleonarun added the dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) label Jul 24, 2023
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment for stylistic consistency with the contract docs example

version: 2

models:
- name: double_nested_fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this name doesn't match the file name above: nested_column_constraints_example

- name: double_nested_fields
config:
contract: {enforced: true}
materialized: table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: don't think this is necessary since we have config(materialized='table') in the sql contents already

@matthewshaver matthewshaver merged commit fd62664 into current Aug 11, 2023
10 checks passed
@matthewshaver matthewshaver deleted the runleonarun-patch-8 branch August 11, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example of colum-level constraint on a nested column in BigQuery
4 participants