-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patch_microbatch_event_time #10712
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10712 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 180 180
Lines 22842 22847 +5
=======================================
+ Hits 20305 20310 +5
Misses 2537 2537
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Was interesting that we needed to do this, glad you figured it out
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Confirmed this does the tricky for dbt-snowflake: dbt-labs/dbt-snowflake#1179 |
Resolves #10713
Problem
using
freeze_time
was not a very precise way to patch just the upper bound for microbatch end time calculation.Solution
Introducing our own method for usage in dbt-core functional tests as well as dbt-test-adapters
Checklist