PostgreSQL: add support for TRIGGERs and FUNCTIONs #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix RETURNS handling, add support for user declared types * Create SQL statement for procedure based on parsed & extra fields
* Add CREATE SCHEMA to DDL * Use table schema-qualified names where possible * Support for diffs on in-db schemas
* tables created without schema object * use qualified name
Otherwise Produced DDL will be broken.
…n void by default
ok 218 - Procedure 'foo_proc'
ok 219 - sql is 'select foo from bar'
ok 220 - parameters are 'foo,bar'
ok 221 - comments is 'Go Sox!'
ok 222 - owner is 'Nomar'
not ok 223 - extra
Failed test ' extra'
at /home/kes/work/projects/github-forks/sql-translator/lib/Test/SQL/Translator.pm line 336.
Structures begin differing at:
$got->{definitions} = ARRAY(0x5d6d4d166398)
$expected->{definitions} = Does not exist
ok 224 - Schema has 2 triggers
Trigger/Procedures implementation discovered bug in Oracle Parser. This change improves Oracle Parser to parse table name for trigger. Anything else stays unchanged.
|
Hi, what should I done here to get it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuation of great work done by @SPodjasek #82
master