Merge pull request #233 from dbatten5/async-search-movie-optional-region

optional region for search async

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "phylm"
-version = "6.1.2"
+version = "6.1.3"
 description = "Phylm"
 authors = ["Dom Batten <[email protected]>"]
 license = "MIT"

src/phylm/clients/tmdb.py

@@ -68,7 +68,7 @@ def search_movies(
         return results
 
     async def search_movies_async(
-        self, query: str, region: str = "us", year: Optional[int] = None
+        self, query: str, region: Optional[str] = None, year: Optional[int] = None
     ) -> List[Dict[str, Any]]:
         """Search for movies async.
 
@@ -91,10 +91,12 @@ async def search_movies_async(
             "language": "en-US",
             "query": query,
             "include_adult": "false",
-            "region": region.upper(),
             "page": 1,
         }
 
+        if region:
+            params["region"] = region
+
         if year:
             params["year"] = year
 

tests/fixtures/vcr_cassettes/clients/tmdb/search_no_results.yaml

@@ -3,7 +3,7 @@ interactions:
       body: null
       headers: {}
       method: GET
-      uri: https://api.themoviedb.org/3/search/movie?include_adult=false&language=en-US&page=1&query=askdjhashdaskdasljd&region=US
+      uri: https://api.themoviedb.org/3/search/movie?include_adult=false&language=en-US&page=1&query=askdjhashdaskdasljd
     response:
       body:
         string: '{"page":1,"results":[],"total_pages":0,"total_results":0}'

tests/fixtures/vcr_cassettes/clients/tmdb/the_matrix_year_async.yaml

@@ -3,7 +3,7 @@ interactions:
       body: null
       headers: {}
       method: GET
-      uri: https://api.themoviedb.org/3/search/movie?include_adult=false&language=en-US&page=1&query=The+Matrix&region=US&year=1999
+      uri: https://api.themoviedb.org/3/search/movie?include_adult=false&language=en-US&page=1&query=The+Matrix&year=1999
     response:
       body:
         string:

tests/fixtures/vcr_cassettes/tmdb/no_results.yaml

@@ -3,7 +3,7 @@ interactions:
       body: null
       headers: {}
       method: GET
-      uri: https://api.themoviedb.org/3/search/movie?api_key=9017d5457c4e8ec5f0999d1b10012ae1&language=en-US&query=asldkjnkasnxlajsnxkasjxnas&include_adult=false&region=US&page=1
+      uri: https://api.themoviedb.org/3/search/movie?api_key=9017d5457c4e8ec5f0999d1b10012ae1&language=en-US&query=asldkjnkasnxlajsnxkasjxnas&include_adult=false&page=1
     response:
       body:
         string: '{"page":1,"results":[],"total_pages":0,"total_results":0}'

tests/fixtures/vcr_cassettes/tmdb/the_matrix_3.yaml

@@ -3,7 +3,7 @@ interactions:
       body: null
       headers: {}
       method: GET
-      uri: https://api.themoviedb.org/3/search/movie?api_key=9017d5457c4e8ec5f0999d1b10012ae1&language=en-US&query=The+Matrix&include_adult=false&region=US&page=1&year=2021
+      uri: https://api.themoviedb.org/3/search/movie?api_key=9017d5457c4e8ec5f0999d1b10012ae1&language=en-US&query=The+Matrix&include_adult=false&page=1&year=2021
     response:
       body:
         string:

tests/unit/clients/test_tmdb.py

@@ -92,7 +92,7 @@ async def test_success(self) -> None:
             f"{VCR_FIXTURES_DIR}/the_matrix_async.yaml",
             filter_query_parameters=["api_key"],
         ) as cass:
-            results = await client.search_movies_async(query="The Matrix")
+            results = await client.search_movies_async(query="The Matrix", region="US")
 
             assert results[0]["title"] == "The Matrix Resurrections"
 
@@ -128,7 +128,6 @@ async def test_success_year(self) -> None:
             ("language", "en-US"),
             ("page", "1"),
             ("query", "The Matrix"),
-            ("region", "US"),
             ("year", "1999"),
         ]
 

tests/unit/sources/test_tmdb.py

@@ -204,7 +204,7 @@ async def test_year(self) -> None:
         tmdb = Tmdb("The Matrix")
         await tmdb.load_source()
 
-        assert tmdb.rating == 8.196
+        assert tmdb.rating == 8.2
 
 
 class TestPlot: