Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binary.yaml #97

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Update binary.yaml #97

merged 3 commits into from
Jun 13, 2024

Conversation

JPietrzykTUD
Copy link
Collaborator

Fixed wrong code for shifting a vector with a scalar value on ARM Neon.

Fixed wrong code for shifting a vector with a scalar value on ARM Neon.
@JPietrzykTUD JPietrzykTUD linked an issue Jun 12, 2024 that may be closed by this pull request
Used correct intrinsic.
As far as I know, using a left shift with a negative value to realize a right shift is not standard compliant. Yet, it seems to be a common workaroung as mentioned by @lawben
Copy link
Collaborator

@alexKrauseTUD alexKrauseTUD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made are undefined in C/C++ but well-defined in ARM Intrinsics.

@JPietrzykTUD JPietrzykTUD merged commit 5692cc4 into main Jun 13, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEON] Shift left requires constant integer
2 participants