-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: npm and pypi publish workflows #8
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: MDzaja <[email protected]>
echo "PACKAGE_VERSION=$PACKAGE_VERSION" >> $GITHUB_ENV | ||
|
||
# Determine npm tag based on version suffix | ||
if [[ "$PACKAGE_VERSION" =~ a[0-9]+$ ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We follow this convention for pre-releases
v0.0.0-alpha.1
v0.0.0-beta.2
v0.0.0-rc.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MDzaja this doesn't seem to be addressed
…it SHA in GH actions Signed-off-by: MDzaja <[email protected]>
… desired convention Signed-off-by: MDzaja <[email protected]>
authors = [ | ||
{ name = "Vedran Jukic", email = "vedran.jukic@gmail.com" }, | ||
{ name = "dummy", email = "dummy@mail.com" }, # TODO: publish-pipeline; change to daytona-org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to name = Daytona, email = [email protected]
This PR introduces two GitHub Actions for automated package publishing:
Both workflows can be triggered either by pushing a Git tag or manually via the GitHub interface. The version for publishing must adhere to one of the following formats:
vX.Y
,vX.Y.Z
,vX.Y.ZaN
,vX.Y.ZbN
,vX.Y.ZrcN
. When triggered manually, the version input should follow the same format. Packages are published withoutv
prefix.Additional Things to Discuss:
packages/python/pyproject.toml
currently uses placeholders and should probably be updated to reflect the Daytona organization ({ name = "dummy", email = "[email protected]" }
). Let me know what to write there.Key Updates:
package.json
andpyproject.toml
are set to0.0.0
and managed dynamically during the publishing process.latest
for stable releases (e.g.,v1.0.0
)alpha
,beta
,release-candidate
for pre-releases (e.g.,v1.0.0a1
,v1.0.0b1
,v1.0.0rc1
)Post-Merge Actions:
Permissions Setup:
Authentication Setup:
NPM_TOKEN
is securely stored in GitHub Secrets.