Skip to content

feat: add auto as usePinchKey to automatically pinch with wheel #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add auto as usePinchKey to automatically pinch with wheel #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2624ec4
feat: add auto as usePinchKey to automatically pinch with wheel
altinselimi Aug 1, 2025
e8e72b8
chore: change implementation to use NULL instead
altinselimi Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/infinite-viewer/src/InfiniteViewerManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,7 @@ class InfiniteViewer extends EventEmitter<InfiniteViewerEvents> {
const pinchDirection = options.pinchDirection;
const maxPinchWheel = options.maxPinchWheel || Infinity;

const isKeydown = e[`${this.wheelPinchKey}Key`] || e.ctrlKey;
const isKeydown = this.wheelPinchKey === null ? true : e[`${this.wheelPinchKey}Key`] || e.ctrlKey;

if (options.useWheelPinch && isKeydown) {
let deltaY = e.deltaY;
Expand Down
4 changes: 2 additions & 2 deletions packages/infinite-viewer/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ export interface InfiniteViewerOptions {
*/
useWheelPinch: boolean;
/**
* Key to use wheel pinch
* Key to use wheel pinch. Null if you want wheel pinch without any key.
* @default "ctrl"
*/
wheelPinchKey: "ctrl" | "meta" | "alt" | "shift",
wheelPinchKey: "ctrl" | "meta" | "alt" | "shift" | null,
/**
* Whether to use wheel scroll. You can scroll smoothly by using the wheel.
* @default IS_SAFARI
Expand Down