Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings GUI #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Settings GUI #4

wants to merge 1 commit into from

Conversation

davidosomething
Copy link
Owner

@davidosomething davidosomething commented Apr 6, 2021

settings

Copy link

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the group name makes your changes work, but a restart of kwin or an unload/reload of the script is needed because the documented options.configChanged signal is not sent when saving the script config :(

I also tried improving the config dialog, but I could not get a KEditListWidget to load in this layout. I could not find a workaround for the manual ln -s either, so all in all it will be a clunky experience for users to edit these.

As an alternative to the config dialog, kwriteconfig5 does the job:

kwriteconfig5 --file kwinrc --group Script-yanjing --key sizes "50,66,34,100"
qdbus org.kde.KWin /KWin reconfigure

WDYT about just keeping the code that reads and parses the sizes option, and documenting this console snippet?

contents/config/main.xml Outdated Show resolved Hide resolved
@davidosomething
Copy link
Owner Author

awesome, i prefer that idea. i'll split the config ui out and release with just the main.js updates

@davidosomething davidosomething changed the title try adding settings to configure sizes Settings GUI Apr 8, 2021
@davidosomething
Copy link
Owner Author

@xvello I released v5.0.0 with config support and no GUI

@davidosomething davidosomething added the help wanted Extra attention is needed label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants