Fix Android KeyboardBehavior detach issue on page navigation #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Android implementation of
KeyboardBehavior
had a critical bug where event handlers were not being properly detached during page navigation:OnAttachedTo()
attached the KeyPress event handler to the parent layout, butOnDetachedFrom()
tried to detach from theplatformView
insteadOnDetachedFrom()
was called, causing crashesSolution
_attachedLayout
field to store reference to the layout that event handlers are attached toOnDetachedFrom()
to detach from the correct layout object_attachedLayout
is always reset to null to prevent memory leaksThis fix ensures proper cleanup for both transient and singleton pages while maintaining consistency with the iOS and Windows implementations.
Fixes #42.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.