jh7100: fix hang during os boot by not to choose hart0 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jh7100 SoC have e24(rv32) in hart0 and u73(rv64) in hart1 and hart2. Prevent opensbi to choose hart0 for the booting core for the os since e24 is not compatible with u73. Signed-off-by: Akira Tsukamoto <[email protected]>
|
I reopened it of the PR #1 |
|
The hart_index2id[] approach used by this PR is not correct. OpenSBI firmwares are built for either RV32 or RV64 but not both. This means the RV32 core on JH7100 is getting stuck somewhere in OpenSBI and does not cleanly enter a WFI based hang loop. I suggest to have add assembly code at start of _start() in fw_base.S which will compare firmware compile time XLEN with runtime XLEN and if there is a mismatch then jump to _start_hang() (which is a WFI loop) Regards, |
|
@avpatel Thank you for your valuable comment. I will add the code in _start() in fw_base.S. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jh7100 SoC have e24(rv32) in hart0 and u73(rv64) in
hart1 and hart2. Prevent opensbi to choose hart0 for the
booting core for the os since e24 is not compatible with u73.
Signed-off-by: Akira Tsukamoto [email protected]