Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove lint reporter #661

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ install:
pnpm install --frozen-lockfile

lint:
pnpm run lint --format eslint-formatter-multiple --max-warnings 0
pnpm run lint --max-warnings 0

unit-test:
pnpm run prebuild:font-subsets
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ jobs:
lint:
name: Lint
uses: ./.github/workflows/reusable-lint.yml
permissions:
checks: write
style:
name: Style
uses: ./.github/workflows/reusable-style.yml
Expand Down
12 changes: 0 additions & 12 deletions .github/workflows/reusable-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ on:
required: false
default: ''

# Add those permissions if reporting test results
# https://github.com/dorny/test-reporter/issues/229
# permissions:
# checks: write

jobs:
code:
name: Code
Expand All @@ -27,13 +22,6 @@ jobs:
uses: ./.github/actions/setup
- name: Run linter
run: cd .ci && make lint
- name: Report results (as status check)
uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5 # v1
if: (success() || failure()) && github.ref == 'refs/heads/main'
with:
name: Lint results
path: '*.xml'
reporter: java-junit

commit-messages:
name: Commit messages
Expand Down
14 changes: 0 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@
"cypress": "13.13.0",
"eslint": "8.57.0",
"eslint-config-prettier": "9.1.0",
"eslint-formatter-multiple": "2.0.0",
"execa": "9.3.0",
"glob": "10.4.2",
"husky": "9.0.11",
Expand All @@ -122,19 +121,6 @@
"typescript": "5.4.5"
},
"packageManager": "[email protected]",
"eslint-formatter-multiple": {
"formatters": [
{
"name": "stylish",
"output": "console"
},
{
"name": "junit",
"output": "file",
"path": "junit-lint.xml"
}
]
},
"repository": {
"type": "git",
"url": "https://github.com/davidlj95/website.git"
Expand Down
10 changes: 0 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading