Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove unit test reporter #660

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ unit-test:
cp ../src/test/mocks/release.json ..

pnpm run test:unit --browsers=ChromeHeadless \
--no-watch --no-progress --reporters junit,progress --code-coverage
--no-watch --no-progress --reporters progress --code-coverage
2 changes: 0 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
test:
name: Test
uses: ./.github/workflows/reusable-test.yml
permissions:
checks: write
secrets:
codecov-token: ${{ secrets.CODECOV_TOKEN }}
lint:
Expand Down
12 changes: 0 additions & 12 deletions .github/workflows/reusable-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ on:
description: Token to use to upload coverage to Codecov. Can be empty for forks https://about.codecov.io/blog/january-product-update-updating-the-codecov-ci-uploaders-to-the-codecov-cli/
required: true

# Add those permissions if reporting test results
# https://github.com/dorny/test-reporter/issues/229
# permissions:
# checks: write

env:
COVERAGE_ARTIFACT_NAME_PREFIX: coverage-
COVERAGE_DIR: coverage
Expand Down Expand Up @@ -50,13 +45,6 @@ jobs:
uses: ./.github/actions/setup
- name: Run tests
run: cd .ci && make unit-test
- name: Report test results (as status check)
uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5 # v1
if: (success() || failure()) && github.ref == 'refs/heads/main'
with:
name: Test results
path: '*.xml'
reporter: java-junit
- name: Upload coverage results
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4
with:
Expand Down
6 changes: 0 additions & 6 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ module.exports = function (config) {
require('karma-jasmine'),
require('karma-chrome-launcher'),
require('karma-jasmine-html-reporter'),
require('karma-junit-reporter'),
require('karma-coverage'),
require('@angular-devkit/build-angular/plugins/karma'),
],
Expand Down Expand Up @@ -44,10 +43,5 @@ module.exports = function (config) {
reporters: ['progress', 'kjhtml'],
browsers: ['Chrome'],
restartOnFileChange: true,
// https://www.npmjs.com/package/karma-junit-reporter#configuration
junitReporter: {
useBrowserName: false,
outputFile: 'junit-test.xml',
},
})
}
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@
"karma-coverage": "2.2.1",
"karma-jasmine": "5.1.0",
"karma-jasmine-html-reporter": "2.1.0",
"karma-junit-reporter": "2.0.1",
"lint-staged": "15.2.7",
"liquidjs": "10.14.0",
"ng-mocks": "14.13.0",
Expand Down
21 changes: 0 additions & 21 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading