Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: configure Codecov #658

Merged

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jul 7, 2024

Does some changes to improve coverage:

  • The const findEntry statement wasn't marked as hit. Probably because inlined by webpack.
  • Same for _onIntersectChanged. Moving everything to another function that sets up & handles changes

This has helped testing a bit Codecov. For instance, seems the Codecov GitHub app needs to be installed for full functionality

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.50%. Comparing base (c2cdbea) to head (00c35e7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   95.51%   95.50%   -0.01%     
==========================================
  Files         122      122              
  Lines         624      623       -1     
  Branches       77       77              
==========================================
- Hits          596      595       -1     
  Misses         20       20              
  Partials        8        8              
Files Coverage Δ
src/app/header/tabs/tabs.component.ts 96.36% <85.71%> (-0.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cdbea...00c35e7. Read the comment docs.

@davidlj95 davidlj95 changed the title refactor: tabs component for coverage purposes test: configure Codecov Jul 7, 2024
@davidlj95 davidlj95 merged commit 17d4ffb into main Jul 8, 2024
14 of 15 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-tabs-component-for-coverage-purposes branch July 8, 2024 21:14
Copy link

🎉 This PR is included in version 2.61.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants