Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add pagination #626

Merged
merged 5 commits into from
Jun 30, 2024
Merged

feat(tabs): add pagination #626

merged 5 commits into from
Jun 30, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jun 19, 2024

Adds pagination to tab group so we can add more navigation tabs that will be visible in small screens whilst telling users that tabs can be scrolled horizontally

TODO

  • On arrow tap, scroll left / right
  • Move active logic to tabs group
  • Remove arrows if tabs fit screen -> more complexity + would introduce layout shift

Other changes:

  • Reduce tab padding
  • Increase bundle size limit, chunk w/ tabs now take > 50kBs gzipped

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@davidlj95 davidlj95 marked this pull request as ready for review June 30, 2024 12:00
@davidlj95 davidlj95 merged commit 37b94e1 into main Jun 30, 2024
11 checks passed
@davidlj95 davidlj95 deleted the slidable-tabs branch June 30, 2024 15:27
Copy link

🎉 This PR is included in version 2.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant