build: add config to render app in pull requests #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
davidlj95
force-pushed
the
add-pull-request-config
branch
from
018e46e
to
6a6d665
Compare
|
🎉 This PR is included in version 2.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
canonicalUrlin environment config is not the proper one when using Cloudflare Pages previews in pull requests. In order to fix that, a new Angular environment is introduced to contain thecanonicalUrlfor this case.Unfortunately, as their docs state, the ID generated for Cloudflare Pages URLs is random.
But it also sets an alias with the branch name, so we can use that to generate the canonical URL for previews.
In order to get the branch name, we use the
GITHUB_HEAD_REFenvironment variable to grab the branch name in CI or callgitCLI when running locally this config for dev purposes.To access that environment variable, the environment file is templated. And template rendering engine sets the branch name.
Also:
Prebuildstep