fix: Differentiate between local and global version symbols in linker-diff#1604
Open
levietduc0712 wants to merge 2 commits intodavidlattimore:mainfrom
Open
Conversation
Owner
|
Note that GNU ld recently switched which version index they use for undefined symbols, so you'll possibly see differences in behaviour between different GNU ld versions |
Contributor
Author
|
Based on your note about GNU ld recently switching which version index it uses for undefined symbols, I've reverted the differentiation and instead replaced the old TODO comment with a clearer explanation of why local and global are treated as equivalent since GNU ld's behavior varies across versions, comparing them would produce false positives. What do you think? |
…ce in linker-diff
levietduc0712
force-pushed
the
differentiate-local-global-version-symbols
branch
from
d225feb to
5d13244
Compare
levietduc0712
changed the title
Collaborator
|
I believe the original TODO comment better captures the problem's fundamental nature. Additionally, while type annotations have been added, this doesn't actually introduce any meaningful changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines how symbol versions are reported in the
read_gnu_versionfunction. Previously, local and global symbols were not differentiated and were both labeled as "local or global". Now, the function distinctly labels version 0 as "local" and version 1 as "global", providing more accurate information.