Skip to content

Conversation

@davidjbradshaw
Copy link
Owner

Add warning for iframes with duplicate IDs.

@davidjbradshaw davidjbradshaw requested a review from Copilot October 1, 2025 15:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds duplicate iframe ID detection functionality to warn users when multiple iframes on the same page share the same ID, which can cause communication issues between iframe and parent page.

  • Added a new checkUniqueId function that detects and warns about duplicate iframe IDs
  • Modified the advise function to handle message formatting with additional arguments
  • Integrated duplicate ID checking into the iframe setup process

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/core/index.js Added duplicate ID checking logic and integrated it into the iframe setup flow
packages/core/console.js Modified the advise function signature to properly handle message formatting with additional arguments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@davidjbradshaw davidjbradshaw requested a review from Copilot October 2, 2025 13:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@davidjbradshaw davidjbradshaw requested a review from Copilot October 2, 2025 13:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@davidjbradshaw davidjbradshaw requested a review from Copilot October 3, 2025 14:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

davidjbradshaw and others added 3 commits October 3, 2025 15:19
…cter sanitization

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@davidjbradshaw davidjbradshaw requested a review from Copilot October 3, 2025 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@davidjbradshaw davidjbradshaw requested a review from Copilot October 3, 2025 14:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@davidjbradshaw davidjbradshaw requested a review from Copilot October 3, 2025 16:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@davidjbradshaw davidjbradshaw merged commit 637f1c2 into master Oct 16, 2025
7 checks passed
@davidjbradshaw davidjbradshaw deleted the id_match branch October 16, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants