Simplify installation using a script #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that it is expected by some clients (for example, wget expects it, while Chrome does just fine without).
Turns out that "install" and "set-default-ca" are separate actions and that only one can be performed per acme.sh invocation (I missed this because acme.sh was already installed when testing).
Using the webroot support in acme.sh means that it is not necessary to stop lighttpd from listening on port 80, which simplifies the configuration.
Automatically redirect e.g. "turris" -> "turris.example.com". Also simplify the README by merging two steps.
This makes the installation process simpler.
Not messing with files under /root seems to be a saner default.
This makes the turris-omnia-tls directory self-contained and reduces the clutter below /srv.
The README.md instructions are fine....automation is even better :D
Using a custom crontab instead of messing with root's crontab makes installation/uninstallation easier.
|
@davidjb: ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a bunch of patches which simplify the installation by providing an installation script.
Also, some bugfixes (2 first patches, should be applied whether you agree with the rest of the PR or not)
Added features:
turris) will be redirected to the FQDN (turris.example.com)acme.shis used via thewebrootfunctionality instead ofstandalone(which means no messing with default turris files or disabling port 80)/rootacme.shis provided by a git submodule