Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-gateway): support v1 authorizer #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FrankSpitulski
Copy link

Proposed changes

this adds support for api gateway v1 authorizers (for http eventsources). right now if you try to use an authorizer that has a canary config api gateway will throw 500 authorizer configuration exceptions.

Types of changes

What types of changes does your code introduce to the plugin?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

tested only locally, didn't want to change the examples too much since it would mean changing the http event source to a complex type. will change if that's okay.

@davidgf
Copy link
Owner

davidgf commented Aug 11, 2020

Thanks a lot for your contribution @FrankSpitulski, and sorry for the late reply. Before merging this PR, could you please add some unit and integration tests? For the latter, you'd only need to create the service configuration, the original CloudFormation template and the expected outcome. You can see examples of that in the fixtures/ folder. Also, could you please modify the sample project (under example/), so that it includes an example of how to use the new functionality? Thanks!

@FrankSpitulski
Copy link
Author

@davidgf I added the example, but I am very much not familiar with CloudFormation. I'm afraid I'll have to leave it here in terms of the CloudFormation template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants