Add feature to expose disabling of auto rollback and disabling of alarms #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hey @davidgf
This PR contains some changes to expose the AutoRollbackConfiguration Enabled flag and expose the AlarmConfiguration Enabled flag for configuration by the user.
Why? So that we can programatically disable these two features when running in an CI. Sometimes we may want to avoid running a deployment with a canary deployment at all as we want to push the change out. We want to be able to say 'Ignore the alarms' and 'Ignore the rollback' thus essentially disabling the plugin for that run.
Types of changes
What types of changes does your code introduce to the plugin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.